linux-kernel - Re: [PATCH v2 09/60] i2c: cp2615: reword according to newest specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zole1BYectz6k2rV@shikoro>
Date: Sat, 6 Jul 2024 17:12:20 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: Bence Csókás <bence98@....bme.hu>
Cc: linux-i2c@...r.kernel.org, Andi Shyti <andi.shyti@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 09/60] i2c: cp2615: reword according to newest
 specification

Hi Bence,

> The diff is cut short, but here would be the comment for the next enum
> element, CP2615_BUS_ERROR, which reads:
> > /* I2C bus error (ie. device NAK'd the request) */
> If you're going for consistency, you might want to edit that as well.

You mean "target NAK'd"? Yes, can do this.

> > -	.master_xfer	= cp2615_i2c_master_xfer,
> > -	.functionality	= cp2615_i2c_func,
> > +	.xfer = cp2615_i2c_xfer,
> > +	.functionality = cp2615_i2c_func,
> >   };
> >   /*
> 
> I don't understand the need for the whitespace changes.

If you have only one space in such struct initializations, you can
change later only the line you are interested in. If you have aligned
them with tabs, you sometimes change one line and need to realign the
whole block. This is annoying and spoils history a little.

> Reviewed-by: Bence Csókás <bence98@....bme.hu>

Thanks!

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)