linux-kernel - Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <8FDD860C-4DA4-46EF-BAD6-8F68837DA993@xenosoft.de>
Date: Sat, 6 Jul 2024 17:54:20 +0200
From: Christian Zigotzky <chzigotzky@...osoft.de>
To: Michael Ellerman <mpe@...erman.id.au>, Marc Zyngier <maz@...nel.org>
Cc: Rob Herring <robh@...nel.org>, apatel@...tanamicro.com,
 DTML <devicetree@...r.kernel.org>,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
 mad skateman <madskateman@...il.com>, "R.T.Dickinson" <rtd2@...a.co.nz>,
 Matthew Leaman <matthew@...on.biz>,
 Darren Stevens <darren@...vens-zone.net>,
 Christian Zigotzky <info@...osoft.de>
Subject: Re: [PowerPC] [PASEMI] Issue with the identification of ATA drives after the of/irq updates 2024-05-29



On 6. Jul 2024, at 06:15, Christian Zigotzky wrote:

Our tester has tested the second irq patch again and the kernel boots. We will test it again to be sure that it really works. ;-)

Second irq patch:

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 462375b293e47..c94203ce65bb3 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -81,7 +81,8 @@ EXPORT_SYMBOL_GPL(of_irq_find_parent);
 /*
  * These interrupt controllers abuse interrupt-map for unspeakable
  * reasons and rely on the core code to *ignore* it (the drivers do
- * their own parsing of the property).
+ * their own parsing of the property). The PAsemi entry covers a
+ * non-sensical interrupt-map that is better left ignored.
  *
  * If you think of adding to the list for something *new*, think
  * again. There is a high chance that you will be sent back to the
@@ -95,6 +96,7 @@ static const char * const of_irq_imap_abusers[] = {
     "fsl,ls1043a-extirq",
     "fsl,ls1088a-extirq",
     "renesas,rza1-irqc",
+    "pasemi,rootbus",
     NULL,
 };

@@ -293,20 +295,8 @@ int of_irq_parse_raw(const __be32 *addr, struct of_phandle_args *out_irq)
             imaplen -= imap - oldimap;
             pr_debug(" -> imaplen=%d\n", imaplen);
         }
-        if (!match) {
-            if (intc) {
-                /*
-                 * The PASEMI Nemo is a known offender, so
-                 * let's only warn for anyone else.
-                 */
-                WARN(!IS_ENABLED(CONFIG_PPC_PASEMI),
-                     "%pOF interrupt-map failed, using interrupt-controller\n",
-                     ipar);
-                return 0;
-            }
-
+        if (!match)
             goto fail;
-        }

         /*
          * Successfully parsed an interrupt-map translation; copy new

-----

Great news! Our tester has tested this second irq patch again and it boots.

Link: https://forum.hyperion-entertainment.com/viewtopic.php?p=58632#p58632

We will use this patch for the kernel 6.10-rc7.

- - Christian