linux-kernel - Re: [PATCH] ARM: dts: qcom: apq8960: correct memory base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ir4hatefzt6luxkjrqro2bf5k7s2hnsw6o75q5543rakh2zpvg@wnnerfjswabz>
Date: Sat, 6 Jul 2024 15:05:03 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: David Heidelberg <david@...t.cz>
Cc: Konrad Dybcio <konrad.dybcio@...aro.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: apq8960: correct memory base

On Sat, Jul 06, 2024 at 12:34:07PM GMT, David Heidelberg wrote:
> Bootloader will provide the information anyway to the kernel.

How about we describe an actual problem here?

Perhaps this is the problem you're solving?:

"""
DeviceTree validation requires a unit address on the memory node, adjust
the base to match [Ref] and use this as unit address.

The bootloader will update the information with the actual values during
boot.
"""

I'd also prefer s/apq8960/msm8960/ in $subject, is there a reason why
you did choose apq8960?

Regards,
Bjorn

> 
> Ref: https://github.com/msm8916-mainline/lk2nd/blob/main/target/msm8960/rules.mk
> 
> Signed-off-by: David Heidelberg <david@...t.cz>
> ---
>  arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> index a9c6d2dbb460..ebc43c5c6e5f 100644
> --- ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> +++ ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> @@ -47,9 +47,9 @@ L2: l2-cache {
>  		};
>  	};
>  
> -	memory {
> +	memory@...00000 {
>  		device_type = "memory";
> -		reg = <0x0 0x0>;
> +		reg = <0x80000000 0>;
>  	};
>  
>  	cpu-pmu {
> -- 
> 2.45.2
>