linux-kernel - Re: [PATCH v2 3/3] i2c: rcar: minor changes to adhere to coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f93eda7e-e65f-42e9-b96d-e88290201ca0@web.de>
Date: Sun, 7 Jul 2024 12:34:36 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>,
 linux-i2c@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Andi Shyti <andi.shyti@...nel.org>
Subject: Re: [PATCH v2 3/3] i2c: rcar: minor changes to adhere to coding style

> A newline was missing and closing braces of functions do not need a
> semicolon.

Can there be a need to offer such changes by separate update steps?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc6#n81


…
> +++ b/drivers/i2c/busses/i2c-rcar.c
> @@ -192,7 +192,7 @@ static int rcar_i2c_get_scl(struct i2c_adapter *adap)
>
>  	return !!(rcar_i2c_read(priv, ICMCR) & FSCL);
>
> -};
> +}
…

How do you think about to omit any blank lines at such source code places?

Regards,
Markus