linux-kernel - Re: [PATCH 09/10] drm/imx: Add i.MX8qxp Display Controller KMS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6595d4fa-2e83-4380-b36e-9c4d910aadea@web.de>
Date: Sun, 7 Jul 2024 21:16:16 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Liu Ying <victor.liu@....com>, dri-devel@...ts.freedesktop.org,
 imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
 kernel@...gutronix.de, devicetree@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>, Conor Dooley <conor+dt@...nel.org>,
 Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...il.com>,
 Fabio Estevam <festevam@...il.com>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
 Rob Herring <robh@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
 Shawn Guo <shawnguo@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Thomas Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH 09/10] drm/imx: Add i.MX8qxp Display Controller KMS

…
> registers of the display controller is accessed without command sequencer
…

Wording suggestion:
  The registers of …                  are …


…
> +++ b/drivers/gpu/drm/imx/dc/dc-crtc.c
> @@ -0,0 +1,578 @@
…
> +static irqreturn_t
> +dc_crtc_dec_framecomplete_irq_handler(int irq, void *dev_id)
> +{
…
> +	spin_lock_irqsave(&crtc->dev->event_lock, flags);
> +	if (dc_crtc->event) {
…
> +	}
> +	spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
> +
> +	return IRQ_HANDLED;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&crtc->dev->event_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc6/source/include/linux/spinlock.h#L574

Regards,
Markus