linux-kernel - Re: [PATCH] cxl core:wrong value of macro definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zow0Aw+vrXShXv+n@aschofie-mobl2>
Date: Mon, 8 Jul 2024 11:46:27 -0700
From: Alison Schofield <alison.schofield@...el.com>
To: peng guo <engguopeng@...a.edu.cn>
Cc: dave@...olabs.net, jonathan.cameron@...wei.com, dave.jiang@...el.com,
	vishal.l.verma@...el.com, ira.weiny@...el.com,
	dan.j.williams@...el.com, linux-cxl@...r.kernel.org,
	linux-kernel@...r.kernel.org, wyguopeng@....com
Subject: Re: [PATCH] cxl core:wrong value of macro definition

On Mon, Jul 08, 2024 at 11:29:02PM +0800, peng guo wrote:
> The first value of the macro definition DEFINE_CXL_VENDOR_DEBUG_UUID
> does not match the definition in the CXL 2.0 specification table 170.

Please update commit message format and make it specific, like:
cxl/core: Support mbox op clear log of vendor debug logs

Isn't that what this is actually doing? It's correcting a typo to enable
the clearing of those logs. If that's true, let's not bury the impact
in a typo headline.

See cxl_payload_from_user_allowed(). I'm guessing that's how you
found this.

--Alison

> 
> Signed-off-by: peng guo <engguopeng@...a.edu.cn>
> ---
>  drivers/cxl/cxlmem.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
> index af8169ccdbc0..feb1106559d2 100644
> --- a/drivers/cxl/cxlmem.h
> +++ b/drivers/cxl/cxlmem.h
> @@ -563,7 +563,7 @@ enum cxl_opcode {
>  		  0x3b, 0x3f, 0x17)
>  
>  #define DEFINE_CXL_VENDOR_DEBUG_UUID                                           \
> -	UUID_INIT(0xe1819d9, 0x11a9, 0x400c, 0x81, 0x1f, 0xd6, 0x07, 0x19,     \
> +	UUID_INIT(0x5e1819d9, 0x11a9, 0x400c, 0x81, 0x1f, 0xd6, 0x07, 0x19,     \
>  		  0x40, 0x3d, 0x86)
>  
>  struct cxl_mbox_get_supported_logs {
> -- 
> 2.43.0
>