linux-kernel - Re: [PATCH sched_ext/for-6.11] sched, sched_ext: Simplify dl_prio() case handling in sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zow2Qls3UF26u5Y1@slm.duckdns.org>
Date: Mon, 8 Jul 2024 08:56:02 -1000
From: Tejun Heo <tj@...nel.org>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>, mingo@...hat.com,
	juri.lelli@...hat.com, vincent.guittot@...aro.org,
	dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
	mgorman@...e.de, bristot@...hat.com, vschneid@...hat.com,
	ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
	martin.lau@...nel.org, joshdon@...gle.com, brho@...gle.com,
	pjt@...gle.com, derkling@...gle.com, haoluo@...gle.com,
	dvernet@...a.com, dschatzberg@...a.com, dskarlat@...cmu.edu,
	riel@...riel.com, changwoo@...lia.com, himadrics@...ia.fr,
	memxor@...il.com, andrea.righi@...onical.com,
	joel@...lfernandes.org, linux-kernel@...r.kernel.org,
	bpf@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH sched_ext/for-6.11] sched, sched_ext: Simplify dl_prio()
 case handling in sched_fork()

On Mon, Jun 24, 2024 at 10:51:49AM -1000, Tejun Heo wrote:
> From: Tejun Heo <tj@...nel.org>
> 
> sched_fork() returns with -EAGAIN if dl_prio(@p). a7a9fc549293 ("sched_ext:
> Add boilerplate for extensible scheduler class") added scx_pre_fork() call
> before it and then scx_cancel_fork() on the exit path. This is silly as the
> dl_prio() block can just be moved above the scx_pre_fork() call.
> 
> Move the dl_prio() block above the scx_pre_fork() call and remove the now
> unnecessary scx_cancel_fork() invocation.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Suggested-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: David Vernet <void@...ifault.com>

Applying to sched_ext/for-6.11.

Thanks.

-- 
tejun