linux-kernel - Re: [PATCH] hfsplus: fix uninit-value in copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202407081219.D7D5914@keescook>
Date: Mon, 8 Jul 2024 12:20:10 -0700
From: Kees Cook <kees@...nel.org>
To: Christian Brauner <brauner@...nel.org>
Cc: syzbot+efde959319469ff8d4d7@...kaller.appspotmail.com,
	Edward Adam Davis <eadavis@...com>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] hfsplus: fix uninit-value in copy_name

On Sat, Jul 06, 2024 at 09:20:30AM +0200, Christian Brauner wrote:
> On Fri, Jul 05, 2024 at 02:20:54PM GMT, Kees Cook wrote:
> > On Tue, 21 May 2024 13:21:46 +0800, Edward Adam Davis wrote:
> > > [syzbot reported]
> > > BUG: KMSAN: uninit-value in sized_strscpy+0xc4/0x160
> > >  sized_strscpy+0xc4/0x160
> > >  copy_name+0x2af/0x320 fs/hfsplus/xattr.c:411
> > >  hfsplus_listxattr+0x11e9/0x1a50 fs/hfsplus/xattr.c:750
> > >  vfs_listxattr fs/xattr.c:493 [inline]
> > >  listxattr+0x1f3/0x6b0 fs/xattr.c:840
> > >  path_listxattr fs/xattr.c:864 [inline]
> > >  __do_sys_listxattr fs/xattr.c:876 [inline]
> > >  __se_sys_listxattr fs/xattr.c:873 [inline]
> > >  __x64_sys_listxattr+0x16b/0x2f0 fs/xattr.c:873
> > >  x64_sys_call+0x2ba0/0x3b50 arch/x86/include/generated/asm/syscalls_64.h:195
> > >  do_syscall_x64 arch/x86/entry/common.c:52 [inline]
> > >  do_syscall_64+0xcf/0x1e0 arch/x86/entry/common.c:83
> > >  entry_SYSCALL_64_after_hwframe+0x77/0x7f
> > > 
> > > [...]
> > 
> > I've taken some security-related hfsplus stuff before, so:
> 
> It's in #vfs.fixes to go out with the next vfs fixes pr.

Ah, thanks! I've dropped it from my tree now.

-- 
Kees Cook