[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZoxCQTub5NH3lLrE@linux.dev>
Date: Mon, 8 Jul 2024 19:47:13 +0000
From: Oliver Upton <oliver.upton@...ux.dev>
To: Sebastian Ene <sebastianene@...gle.com>
Cc: akpm@...ux-foundation.org, alexghiti@...osinc.com, ankita@...dia.com,
ardb@...nel.org, catalin.marinas@....com,
christophe.leroy@...roup.eu, james.morse@....com,
vdonnefort@...gle.com, mark.rutland@....com, maz@...nel.org,
rananta@...gle.com, ryan.roberts@....com, shahuang@...hat.com,
suzuki.poulose@....com, will@...nel.org, yuzenghui@...wei.com,
kvmarm@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, kernel-team@...roid.com
Subject: Re: [PATCH v7 5/6] KVM: arm64: Initialize the ptdump parser with
stage-2 attributes
On Mon, Jul 01, 2024 at 02:17:53PM +0000, Sebastian Ene wrote:
> > <snip>
> >
> > > + }, {
> > > + .mask = PTE_NG,
> > > + .val = PTE_NG,
> > > + .set = "FnXS",
> > > + .clear = " ",
> > > + }, {
> > > + .mask = PTE_CONT | PTE_VALID,
> > > + .val = PTE_CONT | PTE_VALID,
> > > + .set = "CON",
> > > + .clear = " ",
> > > + }, {
> >
> > </snip>
> >
> > Neither of these bits are used at stage-2, why have descriptors for
> > them?
> >
>
> Atm, we don't make use of the contiguous bit in stage-2 in upstream (but
> we have it in some experimental patches). I can remove this, no hard
> feelings for them.
Yes, please drop them. I'll nag whoever adds contpte support for stage-2
to add them back :)
--
Thanks,
Oliver
Powered by blists - more mailing lists