linux-kernel - Re: [PATCH 1/4] dt-bindings: spi: amlogic,a1-spifc: make power-domains required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6add148f-efe7-4444-82b3-20b1198c6d07@kernel.org>
Date: Mon, 8 Jul 2024 21:51:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: George Stark <gnstark@...utedevices.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, neil.armstrong@...aro.org,
 khilman@...libre.com, jbrunet@...libre.com,
 martin.blumenstingl@...glemail.com, hkallweit1@...il.com,
 broonie@...nel.org, glaroque@...libre.com, rafael@...nel.org,
 daniel.lezcano@...aro.org, rui.zhang@...el.com, lukasz.luba@....com,
 b.galvani@...il.com, mmkurbanov@...rdevices.ru
Cc: linux-i2c@...r.kernel.org, linux-spi@...r.kernel.org,
 linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-amlogic@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, kernel@...utedevices.com
Subject: Re: [PATCH 1/4] dt-bindings: spi: amlogic,a1-spifc: make
 power-domains required

On 08/07/2024 21:48, George Stark wrote:
> SPI Flash Controller has dedicated power domain so make the
> corresponding property required.

That's an ABI break. Being part of power domain does not necessarily
mean it must be required, so your commit msg lacks rationale. Especially
on the ABI part.



Best regards,
Krzysztof