linux-kernel - Re: [PATCH 01/10] dt-bindings: display: imx: Add some i.MX8qxp Display Controller processing units

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240708200431.GA3492466-robh@kernel.org>
Date: Mon, 8 Jul 2024 14:04:31 -0600
From: Rob Herring <robh@...nel.org>
To: Liu Ying <victor.liu@....com>
Cc: Krzysztof Kozlowski <krzk@...nel.org>, dri-devel@...ts.freedesktop.org,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	p.zabel@...gutronix.de, airlied@...il.com, daniel@...ll.ch,
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	tzimmermann@...e.de, krzk+dt@...nel.org, conor+dt@...nel.org,
	shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
	festevam@...il.com, tglx@...utronix.de
Subject: Re: [PATCH 01/10] dt-bindings: display: imx: Add some i.MX8qxp
 Display Controller processing units

On Mon, Jul 08, 2024 at 02:30:37PM +0800, Liu Ying wrote:
> On 07/07/2024, Krzysztof Kozlowski wrote:
> > On 05/07/2024 11:09, Liu Ying wrote:
> >> Freescale i.MX8qxp Display Controller is implemented as construction set of
> >> building blocks with unified concept and standardized interfaces.
> >>
> >> Document some processing units to support two display outputs.
> > 
> > 
> >> +maintainers:
> >> +  - Liu Ying <victor.liu@....com>
> >> +
> >> +properties:
> >> +  compatible:
> >> +    const: fsl,imx8qxp-dc-tcon
> >> +
> >> +  reg:
> >> +    maxItems: 1
> >> +
> >> +  fsl,dc-tc-id:
> >> +    description: Timing Controller unit instance number
> > 
> > No instance numbering. This applies to your entire patchset.
> 
> Then, I'll call of_alias_get_id() from the drivers to get
> instance number instead.

Ideally, no.

> As i.MX8qm SoC embeds two Display Controllers, the alias
> stem would contain the Display Controller instance
> number, like "dc0-tcon" and "dc1-tcon".  Is this ok?

The format of aliases is fooN, so no. Aliases should also be generic 
rather than vendor specific.

If you need to describe the connection of components in the display 
pipeline, then use the graph binding.

Rob