linux-kernel - [PATCH 1/1] initrd: use O_SYNC flag while opening /dev/ram for write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240708200923.1824270-1-gnstark@salutedevices.com>
Date: Mon, 8 Jul 2024 23:09:23 +0300
From: George Stark <gnstark@...utedevices.com>
To: <linux-kernel@...r.kernel.org>
CC: <kernel@...utedevices.com>, George Stark <gnstark@...utedevices.com>
Subject: [PATCH 1/1] initrd: use O_SYNC flag while opening /dev/ram for write

initrd image is written to the /dev/ram block device using filp_open(),
kernel_write(). After fput() /dev/ram is mounted and may fail due to not
all data is actually written to the device yet. The mount error remains
hidden due to MS_SILENT flag usage and mount_root_generic has retries.
So use O_SYNC flag to have all data written to /dev/ram before mounting.

Signed-off-by: George Stark <gnstark@...utedevices.com>
---
 init/do_mounts_rd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/do_mounts_rd.c b/init/do_mounts_rd.c
index ac021ae6e6fa..c9a4721c8362 100644
--- a/init/do_mounts_rd.c
+++ b/init/do_mounts_rd.c
@@ -195,7 +195,7 @@ int __init rd_load_image(char *from)
 	char rotator[4] = { '|' , '/' , '-' , '\\' };
 #endif
 
-	out_file = filp_open("/dev/ram", O_RDWR, 0);
+	out_file = filp_open("/dev/ram", O_RDWR | O_SYNC, 0);
 	if (IS_ERR(out_file))
 		goto out;
 
-- 
2.25.1