linux-kernel - Re: [PATCH 1/4] dt-bindings: spi: amlogic,a1-spifc: make power-domains required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172047529524.3973694.1825285851935530574.robh@kernel.org>
Date: Mon, 08 Jul 2024 15:48:15 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: George Stark <gnstark@...utedevices.com>
Cc: rafael@...nel.org, krzk+dt@...nel.org, hkallweit1@...il.com, 
 b.galvani@...il.com, lukasz.luba@....com, conor+dt@...nel.org, 
 rui.zhang@...el.com, broonie@...nel.org, devicetree@...r.kernel.org, 
 linux-pm@...r.kernel.org, neil.armstrong@...aro.org, 
 daniel.lezcano@...aro.org, linux-arm-kernel@...ts.infradead.org, 
 linux-kernel@...r.kernel.org, khilman@...libre.com, 
 mmkurbanov@...rdevices.ru, linux-spi@...r.kernel.org, 
 martin.blumenstingl@...glemail.com, linux-i2c@...r.kernel.org, 
 jbrunet@...libre.com, glaroque@...libre.com, 
 linux-amlogic@...ts.infradead.org, kernel@...utedevices.com
Subject: Re: [PATCH 1/4] dt-bindings: spi: amlogic,a1-spifc: make
 power-domains required


On Mon, 08 Jul 2024 22:48:05 +0300, George Stark wrote:
> SPI Flash Controller has dedicated power domain so make the
> corresponding property required.
> 
> Signed-off-by: George Stark <gnstark@...utedevices.com>
> ---
>  Documentation/devicetree/bindings/spi/amlogic,a1-spifc.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/spi/amlogic,a1-spifc.example.dtb: spi@...00400: Unevaluated properties are not allowed ('power-domains' was unexpected)
	from schema $id: http://devicetree.org/schemas/spi/amlogic,a1-spifc.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240708194808.1819185-2-gnstark@salutedevices.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.