linux-kernel - Re: [PATCH v2 3/3] drm/panel: jd9365da: Break some CMDS into helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=VssfZBxwh6i4e_mHhT8vZ_CnXCrUhoeTUeo5xN-FmASg@mail.gmail.com>
Date: Mon, 8 Jul 2024 15:02:11 -0700
From: Doug Anderson <dianders@...omium.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Cong Yang <yangcong5@...qin.corp-partner.google.com>, sam@...nborg.org, 
	neil.armstrong@...aro.org, daniel@...ll.ch, swboyd@...omium.org, 
	airlied@...il.com, dmitry.baryshkov@...aro.org, 
	krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org, conor+dt@...nel.org, 
	lvzhaoxiong@...qin.corp-partner.google.com, dri-devel@...ts.freedesktop.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] drm/panel: jd9365da: Break some CMDS into helper functions

Hi,

On Thu, Jul 4, 2024 at 1:03 AM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> On Thu, Jul 4, 2024 at 6:50 AM Cong Yang
> <yangcong5@...qin.corp-partner.google.com> wrote:
>
> > These panels have some common cmds (e0h~e3h,80h), let's break
> > them into helper functions.
> >
> > Signed-off-by: Cong Yang <yangcong5@...qin.corp-partner.google.com>
>
> This is a good start! :)
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
>
> If you get time one of these days, see if you can add some defines for
> the other vendor DCS commands as well, but no hurry with that,
> let's merge this series first.

I agree with Linus. It would be great to take this further, but this
is a good start and I'm OK with it merging.

Reviewed-by: Douglas Anderson <dianders@...omium.org>

I'd tend to assume that Neil will merge this series with the various
Acks/Reviews. If I see it hasn't been merged after a while or Neil
says he's busy then I'm happy to land it.

-Doug