linux-kernel - Re: [PATCH v6 2/2] drivers: hwmon: sophgo: Add SG2042 external hardware monitor support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <IA1PR20MB495309AA07F1B77D4DA1EF6BBBDA2@IA1PR20MB4953.namprd20.prod.outlook.com>
Date: Tue, 9 Jul 2024 06:15:39 +0800
From: Inochi Amaoto <inochiama@...look.com>
To: Chen Wang <unicorn_wang@...look.com>, 
	Inochi Amaoto <inochiama@...look.com>, Jean Delvare <jdelvare@...e.com>, 
	Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jonathan Corbet <corbet@....net>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>
Cc: linux-hwmon@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v6 2/2] drivers: hwmon: sophgo: Add SG2042 external
 hardware monitor support

On Mon, Jul 08, 2024 at 03:11:37PM GMT, Chen Wang wrote:
> 
> On 2024/7/8 8:53, Inochi Amaoto wrote:
> > On Mon, Jul 08, 2024 at 08:25:55AM GMT, Chen Wang wrote:
> > > On 2024/7/3 10:30, Inochi Amaoto wrote:
> > > > SG2042 use an external MCU to provide basic hardware information
> > > > and thermal sensors.
> > > > 
> > > > Add driver support for the onboard MCU of SG2042.
> > > > 
> > > > Signed-off-by: Inochi Amaoto <inochiama@...look.com>
> > > > ---
> > > >    Documentation/hwmon/index.rst |   1 +
> > > >    Documentation/hwmon/sgmcu.rst |  44 +++
> > > >    drivers/hwmon/Kconfig         |  11 +
> > > >    drivers/hwmon/Makefile        |   1 +
> > > >    drivers/hwmon/sgmcu.c         | 585 ++++++++++++++++++++++++++++++++++
> > > >    5 files changed, 642 insertions(+)
> > > >    create mode 100644 Documentation/hwmon/sgmcu.rst
> > > >    create mode 100644 drivers/hwmon/sgmcu.c
> > > > 
> > > > diff --git a/Documentation/hwmon/index.rst b/Documentation/hwmon/index.rst
> > > > index 03d313af469a..189626b3a055 100644
> > > > --- a/Documentation/hwmon/index.rst
> > > > +++ b/Documentation/hwmon/index.rst
> > > > @@ -203,6 +203,7 @@ Hardware Monitoring Kernel Drivers
> > > >       sch5636
> > > >       scpi-hwmon
> > > >       sfctemp
> > > > +   sgmcu
> > > This driver is for sg2042 only, right? "sgmcu" looks be general for all
> > > sophgo products.
> > Yes, according to sophgo, it use this mechanism for multiple products,
> > so I switch to a general name.
> 
> But multiple != ALL.
> 
> [......]
> 
> 

We can add new driver when there is new mechanism.