linux-kernel - Re: [PATCH v2] cpufreq: mediatek: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240708065222.iip3hzlffn2dthjg@vireshk-i7>
Date: Mon, 8 Jul 2024 12:22:22 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Nícolas F. R. A. Prado <nfraprado@...labora.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	kernel@...labora.com, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2] cpufreq: mediatek: Use dev_err_probe in every error
 path in probe

On 05-07-24, 11:54, Nícolas F. R. A. Prado wrote:
> Use the dev_err_probe() helper to log the errors on every error path in
> the probe function and its sub-functions. This includes
> * adding error messages where there was none
> * converting over dev_err/dev_warn
> * removing the top-level error message after mtk_cpu_dvfs_info_init() is
>   called, since every error path inside that function already logs the
>   error reason. This gets rid of the misleading error message when probe
>   is deferred:
> 
>     mtk-cpufreq mtk-cpufreq: failed to initialize dvfs info for cpu0
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> ---
> Changes in v2:
> - Fixed one occurrence of the error code being set after the usage
> - For the paths that need to set the `ret` variable to the error code,
>   changed them so they set it from dev_err_probe()'s return, in a single
>   line.
> - Link to v1: https://lore.kernel.org/r/20240628-mtk-cpufreq-dvfs-fail-init-err-v1-1-19c55db23011@collabora.com
> ---
>  drivers/cpufreq/mediatek-cpufreq.c | 72 ++++++++++++++++++--------------------
>  1 file changed, 34 insertions(+), 38 deletions(-)

Applied. Thanks.

-- 
viresh