linux-kernel - Re: [PATCH v2] pci: bus: only call of_platform_populate() if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACMJSevHmnuDk8hpK8W+R7icySmNF8nT1T9+dJDE_KMd4CbGNg@mail.gmail.com>
Date: Mon, 8 Jul 2024 08:52:20 +0200
From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
To: Krzysztof Wilczyński <kw@...ux.com>
Cc: Lukas Wunner <lukas@...ner.de>, Bert Karwatzki <spasswolf@....de>, caleb.connolly@...aro.org, 
	bhelgaas@...gle.com, amit.pundir@...aro.org, neil.armstrong@...aro.org, 
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org, 
	Praveenkumar Patil <PraveenKumar.Patil@....com>, Mario Limonciello <mario.limonciello@....com>
Subject: Re: [PATCH v2] pci: bus: only call of_platform_populate() if
 CONFIG_OF is enabled

On Mon, 8 Jul 2024 at 02:37, Krzysztof Wilczyński <kw@...ux.com> wrote:
>
> Hello,
>
> > > If of_platform_populate() is called when CONFIG_OF is not defined this
> > > leads to spurious error messages of the following type:
> > >  pci 0000:00:01.1: failed to populate child OF nodes (-19)
> > >  pci 0000:00:02.1: failed to populate child OF nodes (-19)
> > >
> > > Fixes: 8fb18619d910 ("PCI/pwrctl: Create platform devices for child OF nodes of the port node")
> > >
> > > Signed-off-by: Bert Karwatzki <spasswolf@....de>
> >
> > Reported-by: Praveenkumar Patil <PraveenKumar.Patil@....com>
> > Closes: https://lore.kernel.org/all/20240702173255.39932-1-superm1@kernel.org/
> > Reviewed-by: Lukas Wunner <lukas@...ner.de>
> > Cc: Mario Limonciello <mario.limonciello@....com>
>
> If there aren't any objections, I will take this via the PCI tree, and add
> the missing tags.  So, no need to send a new version of this patch.
>
> Thank you for the work here!  Appreciated.
>
>         Krzysztof

I don't think you can take it via the PCI tree as it depends on the
changes that went via the new pwrseq tree (with Bjorn's blessing).
Please leave your Ack here and I will take it with the other PCI
pwrctl changes.

After the upcoming merge window we should go back to normal.

Bart