linux-kernel - Re: [PATCH 1/1] i3c: master: svc: Improve DAA STOP handle code logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240708085310.5c5f5521@xps-13>
Date: Mon, 8 Jul 2024 08:53:10 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Frank Li <Frank.Li@....com>
Cc: Conor Culhane <conor.culhane@...vaco.com>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>, linux-i3c@...ts.infradead.org (moderated
 list:SILVACO I3C DUAL-ROLE MASTER), linux-kernel@...r.kernel.org (open
 list), imx@...ts.linux.dev
Subject: Re: [PATCH 1/1] i3c: master: svc: Improve DAA STOP handle code
 logic

Hi Frank,

Frank.Li@....com wrote on Tue,  2 Jul 2024 18:31:07 -0400:

> The REQUEST_PROC_DAA command behaves differently from other commands.
> Sometimes the hardware can auto emit STOP, but in other conditions, it
> cannot.
> 
> Improves the code logic to better handle these situations.
> 
> Hardware can auto emit STOP only when the following conditions are met:
> - The previous I3C device correctly returns a PID and ACKs an I3C address.
> - A NACK is received when emitting 7E to try to get the next I3C device's
> PID.
> 
> In all other cases, a manual STOP emission is needed.
> 
> The code is changed to emit STOP when break the while loop and 'return 0'
> only when the hardware can auto emit STOP.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>

Looks sensible to me.

Reviewed-by: Miquel Raynal <miquel.raynal@...tlin.com>

Thanks,
Miquèl