linux-kernel - Re: [PATCH] vdpa/mlx5: Add the support of set mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEtOP_Hz=SO+r5WQfWow3Pb-Sz552xnt0BqTgyGSuvJz_A@mail.gmail.com>
Date: Mon, 8 Jul 2024 15:03:07 +0800
From: Jason Wang <jasowang@...hat.com>
To: Cindy Lu <lulu@...hat.com>
Cc: dtatulea@...dia.com, mst@...hat.com, parav@...dia.com, sgarzare@...hat.com, 
	netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org, 
	linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH] vdpa/mlx5: Add the support of set mac address

On Mon, Jul 8, 2024 at 2:56 PM Cindy Lu <lulu@...hat.com> wrote:
>
> Add the function to support setting the MAC address.
> For vdpa/mlx5, the function will use mlx5_mpfs_add_mac
> to set the mac address
>
> Tested in ConnectX-6 Dx device

Great.

>
> Signed-off-by: Cindy Lu <lulu@...hat.com>

I guess this should be part of the series "vdpa: support set mac
address from vdpa tool" ?

> ---
>  drivers/vdpa/mlx5/net/mlx5_vnet.c | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> index 26ba7da6b410..f78701386690 100644
> --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
> +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
> @@ -3616,10 +3616,33 @@ static void mlx5_vdpa_dev_del(struct vdpa_mgmt_dev *v_mdev, struct vdpa_device *
>         destroy_workqueue(wq);
>         mgtdev->ndev = NULL;
>  }
> +static int mlx5_vdpa_set_attr_mac(struct vdpa_mgmt_dev *v_mdev,
> +                                 struct vdpa_device *dev,
> +                                 const struct vdpa_dev_set_config *add_config)
> +{
> +       struct mlx5_vdpa_dev *mvdev = to_mvdev(dev);
> +       struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
> +       struct mlx5_core_dev *mdev = mvdev->mdev;
> +       struct virtio_net_config *config = &ndev->config;
> +       int err;
> +       struct mlx5_core_dev *pfmdev;
> +
> +       if (add_config->mask & (1 << VDPA_ATTR_DEV_NET_CFG_MACADDR)) {
> +               if (!is_zero_ether_addr(add_config->net.mac)) {
> +                       memcpy(config->mac, add_config->net.mac, ETH_ALEN);
> +                       pfmdev = pci_get_drvdata(pci_physfn(mdev->pdev));
> +                       err = mlx5_mpfs_add_mac(pfmdev, config->mac);
> +                       if (err)
> +                               return -1;
> +               }
> +       }
> +       return 0;
> +}
>
>  static const struct vdpa_mgmtdev_ops mdev_ops = {
>         .dev_add = mlx5_vdpa_dev_add,
>         .dev_del = mlx5_vdpa_dev_del,
> +       .dev_set_attr = mlx5_vdpa_set_attr_mac,

Let's rename this as we will add the support for mtu as well or not?

Thanks

>  };
>
>  static struct virtio_device_id id_table[] = {
> --
> 2.45.0
>