[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240708072208.25244-1-ed.tsai@mediatek.com>
Date: Mon, 8 Jul 2024 15:22:06 +0800
From: <ed.tsai@...iatek.com>
To: Matthew Wilcox <willy@...radead.org>, Miklos Szeredi <miklos@...redi.hu>,
Amir Goldstein <amir73il@...il.com>, Alexander Viro
<viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>, Jan Kara
<jack@...e.cz>, Matthias Brugger <matthias.bgg@...il.com>, AngeloGioacchino
Del Regno <angelogioacchino.delregno@...labora.com>
CC: <chun-hung.wu@...iatek.com>, Ed Tsai <ed.tsai@...iatek.com>,
<linux-fsdevel@...r.kernel.org>, <linux-unionfs@...r.kernel.org>,
<linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-mediatek@...ts.infradead.org>
Subject: [PATCH 1/1] backing-file: convert to using fops->splice_write
From: Ed Tsai <ed.tsai@...iatek.com>
Filesystems may define their own splice write. Therefore, use the file
fops instead of invoking iter_file_splice_write() directly.
Signed-off-by: Ed Tsai <ed.tsai@...iatek.com>
---
fs/backing-file.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/fs/backing-file.c b/fs/backing-file.c
index afb557446c27..8860dac58c37 100644
--- a/fs/backing-file.c
+++ b/fs/backing-file.c
@@ -303,13 +303,16 @@ ssize_t backing_file_splice_write(struct pipe_inode_info *pipe,
if (WARN_ON_ONCE(!(out->f_mode & FMODE_BACKING)))
return -EIO;
+ if (!out->f_op->splice_write)
+ return -EINVAL;
+
ret = file_remove_privs(ctx->user_file);
if (ret)
return ret;
old_cred = override_creds(ctx->cred);
file_start_write(out);
- ret = iter_file_splice_write(pipe, out, ppos, len, flags);
+ ret = out->f_op->splice_write(pipe, out, ppos, len, flags);
file_end_write(out);
revert_creds(old_cred);
--
2.18.0
Powered by blists - more mailing lists