linux-kernel - Re: [PATCH 1/5] virtio_blk: Fix default logical block size fallback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240708073957.GA38033@dynamic-pd01.res.v6.highway.a1.net>
Date: Mon, 8 Jul 2024 09:39:57 +0200
From: Stefan Hajnoczi <stefanha@...hat.com>
To: John Garry <john.g.garry@...cle.com>
Cc: axboe@...nel.dk, mst@...hat.com, jasowang@...hat.com,
	xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
	pbonzini@...hat.com, hare@...e.de, kbusch@...nel.org, hch@....de,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	virtualization@...ts.linux.dev
Subject: Re: [PATCH 1/5] virtio_blk: Fix default logical block size fallback

On Fri, Jul 05, 2024 at 11:51:23AM +0000, John Garry wrote:
> If we fail to read a logical block size in virtblk_read_limits() ->
> virtio_cread_feature(), then we default to what is in
> lim->logical_block_size, but that would be 0.
> 
> We can deal with lim->logical_block_size = 0 later in the
> blk_mq_alloc_disk(), but the code in virtblk_read_limits() needs a proper
> default, so give a default of SECTOR_SIZE.
> 
> Fixes: 27e32cd23fed ("block: pass a queue_limits argument to blk_mq_alloc_disk")
> Signed-off-by: John Garry <john.g.garry@...cle.com>
> ---
>  drivers/block/virtio_blk.c | 26 +++++++++++++-------------
>  1 file changed, 13 insertions(+), 13 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)