linux-kernel - Re: [PATCH v4 2/3] kernel/fork.c: get totalram_pages from memblock to calculate max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c3ebd1a-09d7-4521-9dea-684d38272a29@redhat.com>
Date: Mon, 8 Jul 2024 09:56:51 +0200
From: David Hildenbrand <david@...hat.com>
To: Wei Yang <richard.weiyang@...il.com>, rppt@...nel.org,
 akpm@...ux-foundation.org, brauner@...nel.org, oleg@...hat.com,
 mjguzik@...il.com, tandersen@...flix.com
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/3] kernel/fork.c: get totalram_pages from memblock to
 calculate max_threads

On 08.07.24 03:00, Wei Yang wrote:
> Since we plan to move the accounting into __free_pages_core(),
> totalram_pages may not represent the total usable pages on system
> at this point when defer_init is enabled.
> 
> Instead we can get the total estimated pages from memblock directly.
> 
> Signed-off-by: Wei Yang <richard.weiyang@...il.com>
> CC: Mike Rapoport (IBM) <rppt@...nel.org>
> CC: David Hildenbrand <david@...hat.com>
> CC: Oleg Nesterov <oleg@...hat.com>
> ---
>   kernel/fork.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/kernel/fork.c b/kernel/fork.c
> index 99076dbe27d8..e80e889543f3 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -44,6 +44,7 @@
>   #include <linux/fs.h>
>   #include <linux/mm.h>
>   #include <linux/mm_inline.h>
> +#include <linux/memblock.h>
>   #include <linux/nsproxy.h>
>   #include <linux/capability.h>
>   #include <linux/cpu.h>
> @@ -999,7 +1000,7 @@ void __init __weak arch_task_cache_init(void) { }
>   static void set_max_threads(unsigned int max_threads_suggested)
>   {
>   	u64 threads;
> -	unsigned long nr_pages = totalram_pages();
> +	unsigned long nr_pages = memblock_estimated_nr_pages();

Stale name

-- 
Cheers,

David / dhildenb