linux-kernel - RE: [PATCH] ARM: dts: microchip: sam9x60: Move i2c address/size to dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH8PR11MB6804471EC8A42CB9BBAB999682DA2@PH8PR11MB6804.namprd11.prod.outlook.com>
Date: Mon, 8 Jul 2024 08:20:07 +0000
From: <Mihai.Sain@...rochip.com>
To: <ada@...rsis.com>, <devicetree@...r.kernel.org>,
	<claudiu.beznea@...on.dev>
CC: <robh@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
	<Nicolas.Ferre@...rochip.com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ARM: dts: microchip: sam9x60: Move i2c address/size to
 dtsi

Hi Alex,

I added Claudiu in the thread.

Regards,
Mihai

-----------------------------------------------------------------

Am Tue, May 28, 2024 at 05:31:09PM +0200 schrieb Alexander Dahl:
> These properties are common for all i2c subnodes, and marked as 
> 'required' in atmel/microchip i2c bindings.  Allows to add i2c device 
> nodes (like an rtc for example) in other .dts files including 
> sam9x60.dtsi without requiring to repeat these properties for each i2c 
> device again and again.
>
> Found on a custom board after adding this in .dts:
>
>     &flx5 {
>             atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
>             status = "okay";
>
>             i2c5: i2c@600 {
>                     pinctrl-0 = <&pinctrl_flx5_default>;
>                     status = "okay";
>
>                     pcf8523: rtc@68 {
>                             compatible = "nxp,pcf8523";
>                             reg = <0x68>;
>                     };
>             };
>     };
>
> … which created a warning like this:
>
>     […]:236.4-17: Warning (reg_format): /ahb/apb/flexcom@...04000/i2c@.../rtc@68:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1)
>     […]: Warning (pci_device_reg): Failed prerequisite 'reg_format'
>     […]: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
>     […]: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
>     […]/linux-6.6.25/arch/arm/boot/dts/microchip/sam9x60.dtsi:283.19-299.7: Warning (i2c_bus_bridge): /ahb/apb/flexcom@...04000/i2c@600: incorrect #address-cells for I2C bus also defined at […]:228.16-238.4
>     […]/linux-6.6.25/arch/arm/boot/dts/microchip/sam9x60.dtsi:283.19-299.7: Warning (i2c_bus_bridge): /ahb/apb/flexcom@...04000/i2c@600: incorrect #size-cells for I2C bus also defined at […]:228.16-238.4
>     […]: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
>     […]: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge'
>     […]: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
>     […]:234.19-237.5: Warning (avoid_default_addr_size): /ahb/apb/flexcom@...04000/i2c@.../rtc@68: Relying on default #address-cells value
>     […]:234.19-237.5: Warning (avoid_default_addr_size): /ahb/apb/flexcom@...04000/i2c@.../rtc@68: Relying on default #size-cells value
>     […]: Warning (avoid_unnecessary_addr_size): Failed prerequisite 'avoid_default_addr_size'
>     […]: Warning (unique_unit_address): Failed prerequisite 'avoid_default_addr_size'
>
> This probably should have been done with commit 84f23f3284d5 ("ARM: dts:
> at91: sam9x60: move flexcom definitions") already, where those 
> address-cells and size-cells properties were left in the board .dts 
> files instead of moving them to the dtsi.

It's been a while.  Is something wrong with the patch?  Or with the commit message?

at91 support seems to have slowed down somehow lately? :-/

Greets
Alex

>
> Signed-off-by: Alexander Dahl <ada@...rsis.com>
> ---
>  .../dts/microchip/at91-sam9x60_curiosity.dts  |  2 --  
> .../arm/boot/dts/microchip/at91-sam9x60ek.dts |  4 ---
>  arch/arm/boot/dts/microchip/sam9x60.dtsi      | 26 +++++++++++++++++++
>  3 files changed, 26 insertions(+), 6 deletions(-)
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
> --
> 2.39.2