linux-kernel - Re: [PATCH] spi: add ch341a usb2spi driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0344c279-a678-4ac9-b4b1-6601f5a5a1aa@kernel.org>
Date: Mon, 8 Jul 2024 13:55:18 +0200
From: Johannes Thumshirn <jth@...nel.org>
To: Mark Brown <broonie@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH] spi: add ch341a usb2spi driver

On 08/07/2024 13:32, Mark Brown wrote:
> On Mon, Jul 08, 2024 at 10:04:41AM +0200, Johannes Thumshirn wrote:
>> On 05/07/2024 19:41, Mark Brown wrote:
> 
>>> No validation of speed?
> 
>> TBH I haven't found a command that reads the current settings of the device.
> 
> Why would reading things from the device be relevant to validating what
> we are writing?

Then I don't really understand your comment.

Why would I need to validate a constant? But indeed it doesn't make any 
sense at all to pass in the speed parameter.

Will fix in v2.