linux-kernel - Re: [PATCH v2] perf: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240708115707.GB11771@willie-the-truck>
Date: Mon, 8 Jul 2024 12:57:07 +0100
From: Will Deacon <will@...nel.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: Mark Rutland <mark.rutland@....com>,
	Jonathan Cameron <jonathan.cameron@...wei.com>,
	Frank Li <Frank.li@....com>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Yicong Yang <yangyicong@...ilicon.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-cxl@...r.kernel.org, imx@...ts.linux.dev,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] perf: add missing MODULE_DESCRIPTION() macros

On Mon, Jul 01, 2024 at 08:38:02AM -0700, Jeff Johnson wrote:
> On 7/1/2024 7:05 AM, Will Deacon wrote:
> > On Thu, Jun 20, 2024 at 06:46:09PM -0700, Jeff Johnson wrote:
> >> diff --git a/drivers/perf/arm_cspmu/nvidia_cspmu.c b/drivers/perf/arm_cspmu/nvidia_cspmu.c
> >> index 5b84b701ad62..0dea47e48ac5 100644
> >> --- a/drivers/perf/arm_cspmu/nvidia_cspmu.c
> >> +++ b/drivers/perf/arm_cspmu/nvidia_cspmu.c
> >> @@ -417,4 +417,5 @@ static void __exit nvidia_cspmu_exit(void)
> >>  module_init(nvidia_cspmu_init);
> >>  module_exit(nvidia_cspmu_exit);
> >>  
> >> +MODULE_DESCRIPTION("NVIDIA Coresight Architecture PMU driver");
> >>  MODULE_LICENSE("GPL v2");
> >> diff --git a/drivers/perf/cxl_pmu.c b/drivers/perf/cxl_pmu.c
> >> index 1f93a66eff5b..8b6ce9ea5a55 100644
> >> --- a/drivers/perf/cxl_pmu.c
> >> +++ b/drivers/perf/cxl_pmu.c
> >> @@ -972,6 +972,7 @@ static __exit void cxl_pmu_exit(void)
> >>  	cpuhp_remove_multi_state(cxl_pmu_cpuhp_state_num);
> >>  }
> >>  
> >> +MODULE_DESCRIPTION("CXL Performance Monitoring Unit driver");
> > 
> > Similarly here, we now have a conflicting expansion of the acronym.
> 
> I'll make them consistent in the MODULE_DESCRIPTION()s.
> Do you have a preference for expanding or not expanding?

PMU is a terrible acronym, so I probably prefer expanding it unless it
causes problems.

Will