linux-kernel - Re: [PATCH net-next v2 01/10] net/sched: flower: refactor tunnel flag definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKa-r6u85yD=Ct4nq2xZLXLT+3vWsz+WoDZ__xS4tkpge=yf-Q@mail.gmail.com>
Date: Mon, 8 Jul 2024 14:07:58 +0200
From: Davide Caratti <dcaratti@...hat.com>
To: Asbjørn Sloth Tønnesen <ast@...erby.net>
Cc: netdev@...r.kernel.org, Ilya Maximets <i.maximets@....org>, 
	Jamal Hadi Salim <jhs@...atatu.com>, Cong Wang <xiyou.wangcong@...il.com>, 
	Jiri Pirko <jiri@...nulli.us>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	David Ahern <dsahern@...nel.org>, Simon Horman <horms@...nel.org>, 
	Ratheesh Kannoth <rkannoth@...vell.com>, Florian Westphal <fw@...len.de>, 
	Alexander Lobakin <aleksander.lobakin@...el.com>, linux-kernel@...r.kernel.org, 
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net-next v2 01/10] net/sched: flower: refactor tunnel flag definitions

hello,

On Mon, Jul 8, 2024 at 1:12 PM Asbjørn Sloth Tønnesen <ast@...erby.net> wrote:
>

[...]

> Davide, I think David Ahern would be happy [1] if you could post a new iproute2 patch,
> since the kernel patches should preferably hit net-next this week (due to uAPI breakage).

I will send an updated patch (don't use "matches" + add missing man
page + rename keywords [1])  in the next hours.
thanks,
-- 
davide

[1]

> Nit: I would prefix all of these with "tun_".

"tun_" or just "tun" ? please note that each flag can have a "no"
prefix, so is it better

notuncsum
notundf
notunoam
notuncrit

or

notun_csum
notun_df
notun_oam
notun_crit

?

(I'm for not using the underscore - but I'm open to ideas: please let me know)