linux-kernel - Re: [PATCH net-next v3 2/2] net: stmmac: qcom-ethqos: enable SGMII loopback during DMA reset on sa8775p-ride-r3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <acc4ebc7-9c82-45a7-ae22-bdf927dd0317@lunn.ch>
Date: Mon, 8 Jul 2024 15:25:31 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH net-next v3 2/2] net: stmmac: qcom-ethqos: enable SGMII
 loopback during DMA reset on sa8775p-ride-r3

On Wed, Jul 03, 2024 at 08:14:59PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> On sa8775p-ride-r3 the RX clocks from the AQR115C PHY are not available at
> the time of the DMA reset. We can however extract the RX clock from the
> internal SERDES block. Once the link is up, we can revert to the
> previous state.
> 
> The AQR115C PHY doesn't support in-band signalling so we can count on
> getting the link up notification and safely reuse existing callbacks
> which are already used by another HW quirk workaround which enables the
> functional clock to avoid a DMA reset due to timeout.
> 
> Only enable loopback on revision 3 of the board - check the phy_mode to
> make sure.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew