linux-kernel - Re: [PATCH 2/3] riscv: dts: sophgo: add nodes for USB phy and controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dfd9822e-6aa7-4873-abaa-f6d8996fb3de@kernel.org>
Date: Mon, 8 Jul 2024 15:41:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yao Zi <ziyao@...root.org>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chen Wang <unicorn_wang@...look.com>,
 Inochi Amaoto <inochiama@...look.com>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Jisheng Zhang <jszhang@...nel.org>, linux-phy@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 2/3] riscv: dts: sophgo: add nodes for USB phy and
 controller

On 08/07/2024 14:08, Yao Zi wrote:
>  
> +		usb_phy: usb-phy@...6000 {
> +			compatible = "sophgo,cv1800-usb-phy";
> +			reg = <0x3006000 0x60>, <0x3000048 0x4>;
> +			reg-names = "phy", "pin";
> +			clocks = <&clk CLK_APB_USB>,
> +				 <&clk CLK_USB_125M>,
> +				 <&clk CLK_USB_33K>,
> +				 <&clk CLK_USB_12M>;
> +			clock-names = "apb", "125m", "33k", "12m";

Why are not you using dr_role property here?

Best regards,
Krzysztof