linux-kernel - [PATCH] kselftests: dmabuf-heaps: Ensure the driver name is null-terminated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240708134654.1725-1-yuzenghui@huawei.com>
Date: Mon, 8 Jul 2024 21:46:54 +0800
From: Zenghui Yu <yuzenghui@...wei.com>
To: <linux-media@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	<linaro-mm-sig@...ts.linaro.org>, <linux-kselftest@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
CC: <sumit.semwal@...aro.org>, <benjamin.gaignard@...labora.com>,
	<Brian.Starkey@....com>, <jstultz@...gle.com>, <tjmercier@...gle.com>,
	<shuah@...nel.org>, <wanghaibin.wang@...wei.com>, Zenghui Yu
	<yuzenghui@...wei.com>
Subject: [PATCH] kselftests: dmabuf-heaps: Ensure the driver name is null-terminated

Even if a vgem device is configured in, we will skip the import_vgem_fd()
test almost every time.

  TAP version 13
  1..11
  # Testing heap: system
  # =======================================
  # Testing allocation and importing:
  ok 1 # SKIP Could not open vgem -1

The problem is that we use the DRM_IOCTL_VERSION ioctl to query the driver
version information but leave the name field a non-null-terminated string.
Terminate it properly to actually test against the vgem device.

Signed-off-by: Zenghui Yu <yuzenghui@...wei.com>
---
 tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
index 5f541522364f..2fcc74998fa9 100644
--- a/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
+++ b/tools/testing/selftests/dmabuf-heaps/dmabuf-heap.c
@@ -32,6 +32,8 @@ static int check_vgem(int fd)
 	if (ret)
 		return 0;
 
+	name[4] = '\0';
+
 	return !strcmp(name, "vgem");
 }
 
-- 
2.33.0