linux-kernel - Re: [PATCH v4 09/11] hwmon: (amc6821) Convert to use regmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e2c378a1-0137-4c31-aa38-34e808406f36@roeck-us.net>
Date: Mon, 8 Jul 2024 07:43:22 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Quentin Schulz <quentin.schulz@...rry.de>, linux-hwmon@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, Farouk Bouabid <farouk.bouabid@...rry.de>
Subject: Re: [PATCH v4 09/11] hwmon: (amc6821) Convert to use regmap

Hi Quentin.On 7/8/24 03:58, Quentin Schulz wrote:

>> +    regval = BIT(5) >> FIELD_GET(AMC6821_TEMP_SLOPE_MASK, regval);
> 
> BIT(5) doesn't have real meaning in the datasheet, what is in the datasheet though is that the slope is 32 / L-SLP[2:0] (well, you can more easily guess it from the datasheet than 0x20 or BIT(5) IMO).
> 

Good point, though it is 32 >> L-SLP[2:0]. I'll make it 32 and add a comment,
but I won't send another version.

>> +        ret = amc6821_get_auto_point_temps(data->regmap, 1 - nr, otemps);
> 
> I would have been more comfortable with
> nr ? 0 : 1
> 

No, because that is a conditional and 1 - nr isn't.

> Only nitpicks, so:
> 
> Reviewed-by: Quentin Schulz <quentin.schulz@...rry.de>
> 

Thanks for the detailed reviews!

Guenter