linux-kernel - Re: [PATCH v2 1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172045066129.3180056.14093408400794143570.robh@kernel.org>
Date: Mon, 8 Jul 2024 08:57:42 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
	Vinod Koul <vkoul@...nel.org>, imx@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Krzysztof Kozlowski <krzk+dt@...nel.org>, dmaengine@...r.kernel.org
Subject: Re: [PATCH v2 1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check
 logic


On Mon, 01 Jul 2024 15:57:16 -0400, Frank Li wrote:
> All compatible string include 'fsl,ls1021a-qdma'. Previous if check are
> always true.
> 
> if:
>   properties:
>     compatible:
>       contains:
>        enum:
>          - fsl,ls1021a-qdma
> 
> Change to check other compatible strings to get correct logic and fix
> below CHECK_DTB warnings.
> 
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb:
> dma-controller@...0000: interrupts: [[0, 43, 4], [0, 251, 4], [0, 252, 4], [0, 253, 4], [0, 254, 4]] is too long
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
> Change from v1 to v2
> - Change  maxItems: 5 to minItems: 5. because maxItems: 5 already restrict
> at top
> 
> interrupts:
>     minItems: 2
>     maxItems: 5
> ---
>  Documentation/devicetree/bindings/dma/fsl-qdma.yaml | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>