[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4ec6b50e-b915-4e18-a8a5-97ca7ab9e4ce@salutedevices.com>
Date: Mon, 8 Jul 2024 18:37:21 +0300
From: George Stark <gnstark@...utedevices.com>
To: Jerome Brunet <jbrunet@...libre.com>
CC: <ukleinek@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
<conor+dt@...nel.org>, <neil.armstrong@...aro.org>, <khilman@...libre.com>,
<martin.blumenstingl@...glemail.com>, <hkallweit1@...il.com>,
<linux-pwm@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-amlogic@...ts.infradead.org>, <linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <kernel@...utedevices.com>, Dmitry Rokosov
<ddrokosov@...utedevices.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: amlogic: Add new bindings for
meson A1 PWM
Hello Jerome
Thanks for the review
On 7/8/24 16:11, Jerome Brunet wrote:
> On Tue 02 Jul 2024 at 15:34, George Stark <gnstark@...utedevices.com> wrote:
>
>> The chip has 3 dual-channel PWM modules PWM_AB, PWM_CD, PWM_EF.
>>
>> Signed-off-by: George Stark <gnstark@...utedevices.com>
>> Signed-off-by: Dmitry Rokosov <ddrokosov@...utedevices.com>
>> ---
>> .../devicetree/bindings/pwm/pwm-amlogic.yaml | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>> index 1d71d4f8f328..e021cf59421a 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
...
>
> The change is not only introducing a1 compatibility but also allowing a
> power-domain for the other SoC, even if optional.
>
> If that is intended, it should be stated in the description and probably
> a separate change.
AFAIK the only SoC with a separate PD for PWM is A1 (currently). I added
PD to bindings by an independent change in series #2 [1] but Rob
proposed it should be squashed into compatible patch. The only thing
missed in series #2 was the conditional schema making PD required for A1.
I personally would prefer to add PD as a separate change.
I'll give it a try.
[1]
https://lore.kernel.org/lkml/20240701172016.523402-1-gnstark@salutedevices.com/T/#m0e004fc0d22e205aa3bf6bdd0284d251f26eb0f3
>
>> "#pwm-cells":
>> const: 3
>>
>> @@ -136,6 +143,16 @@ allOf:
>> required:
>> - clocks
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - amlogic,meson-a1-pwm
>> + then:
>> + required:
>> + - power-domains
>> +
>> additionalProperties: false
>>
>> examples:
>
--
Best regards
George
Powered by blists - more mailing lists