linux-kernel - Re: [PATCH v3 1/3] kernfs: remove page_mkwrite() from vm_operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0daca554-89fe-4926-adb7-d4cd2e855d66@eideticom.com>
Date: Mon, 8 Jul 2024 10:31:42 -0600
From: Martin Oliveira <martin.oliveira@...eticom.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: Matthew Wilcox <willy@...radead.org>, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, linux-rdma@...r.kernel.org,
 Andrew Morton <akpm@...ux-foundation.org>,
 Artemy Kovalyov <artemyko@...dia.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Jason Gunthorpe <jgg@...pe.ca>, Leon Romanovsky <leon@...nel.org>,
 Logan Gunthorpe <logang@...tatee.com>,
 Michael Guralnik <michaelgur@...dia.com>,
 Mike Marciniszyn <mike.marciniszyn@...el.com>, Tejun Heo <tj@...nel.org>,
 John Hubbard <jhubbard@...dia.com>, Dan Williams <dan.j.williams@...el.com>,
 David Sloan <david.sloan@...eticom.com>
Subject: Re: [PATCH v3 1/3] kernfs: remove page_mkwrite() from
 vm_operations_struct

On 2024-07-05 01:20, Christoph Hellwig wrote:
> Btw, sorry if I mislead you with my WARN_ON_ONCE suggestion.  That
> was always intended in addition to the error handling, not instead.
> (In fact there are very few reasons to use WARN_ON* without actually
> handling the error as well).

Yeah, I should have caught that. Thanks for the feedback, Christoph!
I'll submit a new version later today.
  
> Yes, doing the same for ->close or anything unimplemented would be
> nice.  But it's not really in scope for this series.
> 
> kernfs really should be using it's own ops instead of abusing
> file_operations, but that's even more out of scope..

Ok, I'll add the ->page_mkwrite with the WARN but leave the ->close
the way it is.

Martin