linux-kernel - Re: [PATCH v2 0/3] Add support for Imagis IST3038 and clarify the usage of protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zowdam9nm4I7FSk3@google.com>
Date: Mon, 8 Jul 2024 10:10:02 -0700
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Raymond Hackley <raymondhackley@...tonmail.com>
Cc: linux-kernel@...r.kernel.org, Markuss Broks <markuss.broks@...il.com>,
	Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Stephan Gerhold <stephan@...hold.net>,
	Nikita Travkin <nikita@...n.ru>, linux-input@...r.kernel.org,
	devicetree@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v2 0/3] Add support for Imagis IST3038 and clarify the
 usage of protocol_b

On Thu, Jun 13, 2024 at 02:56:46AM +0000, Raymond Hackley wrote:
> Imagis IST3038 is another variant of Imagis IST3038 IC, which has
> a different register interface from IST3038C (possibly firmware defined).
> 
> Unlike IST3038C/IST3032C, IST3038 has different registers for commands,
> which means IST3038 doesn't use protocol B.
> Similar to IST3032C and maybe the other variants, IST3038 has touch keys
> support, which provides KEY_APPSELECT and KEY_BACK.
> 
> Add support for IST3038 with touch keys.
> 
> protocol_b is a property, which tells Imagis panel to use a different
> format for coordinates.
> 
> IST30XXC series is known for using protocol B, while the other series
> aren't. Note this could be confusing, unlike the model name implies.
> 
> Adjust the usage of protocol_b to avoid confusion.
> 
> ---
> v2: Sort the compatible enties in alphabetical order.
>     Document the binding before using in the driver.
> 

Applied the lot, thank you.

-- 
Dmitry