linux-kernel - Re: [PATCH v2 2/2] sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zowt7pVWFB-Of-me@slm.duckdns.org>
Date: Mon, 8 Jul 2024 08:20:30 -1000
From: Tejun Heo <tj@...nel.org>
To: Vincent Guittot <vincent.guittot@...aro.org>
Cc: rafael@...nel.org, viresh.kumar@...aro.org, linux-pm@...r.kernel.org,
	void@...ifault.com, linux-kernel@...r.kernel.org,
	kernel-team@...a.com, mingo@...hat.com, peterz@...radead.org,
	David Vernet <dvernet@...a.com>,
	"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH v2 2/2] sched_ext: Add cpuperf support

Hello, Vincent.

On Mon, Jul 08, 2024 at 08:37:06AM +0200, Vincent Guittot wrote:
> I prefer to minimize (if not remove) sched_ext related calls in the
> fair path so we can easily rework it if needed. And this will also
> ensure that all fair task are cleanly removed when they are all
> switched to sched_ext

Unless we add a WARN_ON_ONCE, if it doesn't behave as expected, the end
result will most likely be cpufreq sometimes picking a higher freq than
requested, which won't be the easiest to notice. Would you be against adding
WARN_ON_ONCE(scx_switched_all && !util) too?

Thanks.

-- 
tejun