linux-kernel - Re: [PATCH v2] drm/amd/display: Add otg_master NULL check within init_pipe_slice_table_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f22c70c9-8102-4ba8-b8e9-6df260110b6b@amd.com>
Date: Tue, 9 Jul 2024 09:01:06 -0600
From: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@....com>
To: Ma Ke <make24@...as.ac.cn>
Cc: amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org,
 harry.wentland@....com, sunpeng.li@....com, alexander.deucher@....com,
 christian.koenig@....com, Xinhui.Pan@....com, airlied@...il.com,
 daniel@...ll.ch, daniel.vetter@...ll.ch, alvin.lee2@....com,
 wenjing.liu@....com, chaitanya.dhere@....com, hamza.mahfooz@....com,
 sohaib.nadeem@....com, samson.tam@....com, Qingqing.Zhuo@....com,
 dillon.varone@....com, stylon.wang@....com, akpm@...ux-foundation.org
Subject: Re: [PATCH v2] drm/amd/display: Add otg_master NULL check within
 init_pipe_slice_table_from_context

On 7/9/24 3:10 AM, Ma Ke wrote:
> To avoid reports of NULL_RETURN warning, we should add
> otg_master NULL check.
> 
> Cc: stable@...r.kernel.org
> Fixes: c51d87202d1f ("drm/amd/display: do not attempt ODM power optimization if minimal transition doesn't exist")
> Signed-off-by: Ma Ke <make24@...as.ac.cn>
> ---
> Changes in v2:
> - added the recipient's email address, due to the prolonged absence of a
> response from the recipient.
> - added Cc stable.
> ---
>   drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
> index f6fe0a64beac..8972598ca77f 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/dcn32_fpu.c
> @@ -1177,6 +1177,9 @@ static void init_pipe_slice_table_from_context(
>   		stream = context->streams[i];
>   		otg_master = resource_get_otg_master_for_stream(
>   				&context->res_ctx, stream);
> +		if (!otg_master)
> +			continue;
> +
>   		count = resource_get_odm_slice_count(otg_master);
>   		update_slice_table_for_stream(table, stream, count);
>   

Hi,

Which repository and branch are you using? It looks like this issue is 
already fixed on amd-staging-drm-next.

Thanks
Siqueira