linux-kernel - Re: [PATCH] drm/panel: sharp-lq101r1sx01: Fixed reversed "if" in remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=UU00oJ0Gi5fhOOk4gCFp1Cg55cA7Gy_GPpVgj95BNNbA@mail.gmail.com>
Date: Tue, 9 Jul 2024 08:26:06 -0700
From: Doug Anderson <dianders@...omium.org>
To: neil.armstrong@...aro.org
Cc: dri-devel@...ts.freedesktop.org, Linus Walleij <linus.walleij@...aro.org>, 
	Dan Carpenter <dan.carpenter@...aro.org>, Maxime Ripard <mripard@...nel.org>, 
	Thierry Reding <treding@...dia.com>, kernel test robot <lkp@...el.com>, Daniel Vetter <daniel@...ll.ch>, 
	David Airlie <airlied@...il.com>, Jessica Zhang <quic_jesszhan@...cinc.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Thomas Zimmermann <tzimmermann@...e.de>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: sharp-lq101r1sx01: Fixed reversed "if" in remove

Hi,

On Tue, Jul 9, 2024 at 12:53 AM Neil Armstrong
<neil.armstrong@...aro.org> wrote:
>
> On 08/07/2024 19:52, Douglas Anderson wrote:
> > Commit d7d473d8464e ("drm/panel: sharp-lq101r1sx01: Don't call disable
> > at shutdown/remove") had a subtle bug. We should be calling
> > sharp_panel_del() when the "sharp" variable is non-NULL, not when it's
> > NULL. Fix.
> >
> > Fixes: d7d473d8464e ("drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/remove")
> > Cc: Thierry Reding <treding@...dia.com>
> > Reported-by: kernel test robot <lkp@...el.com>
> > Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> > Closes: https://lore.kernel.org/r/202406261525.SkhtM3ZV-lkp@intel.com/
> > Signed-off-by: Douglas Anderson <dianders@...omium.org>
> > ---
> >
> >   drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c b/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
> > index edc9425bb143..a0d76d588da1 100644
> > --- a/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
> > +++ b/drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
> > @@ -362,7 +362,7 @@ static void sharp_panel_remove(struct mipi_dsi_device *dsi)
> >               dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err);
> >
> >       /* only detach from host for the DSI-LINK2 interface */
> > -     if (!sharp)
> > +     if (sharp)
> >               sharp_panel_del(sharp);
> >   }
> >
>
> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>

Thanks! I've pushed to "drm-misc-next-fixes" since it's after -rc6 and
the problematic patch is in drm-next.

[1/1] drm/panel: sharp-lq101r1sx01: Fixed reversed "if" in remove
      commit: ec85147a3529fded4bba12b48623f3a2587af83f