linux-kernel - Re: [PATCH] clk: imx: imx8: Add .name for "acm_aud_clk0_sel" and "acm_aud_clk1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA+D8APumdP97QQHObF6NEw6jwDJRb+0R=aAjqftrX1wR170Yw@mail.gmail.com>
Date: Tue, 9 Jul 2024 11:20:56 +0800
From: Shengjiu Wang <shengjiu.wang@...il.com>
To: Stephen Boyd <sboyd@...nel.org>
Cc: Shengjiu Wang <shengjiu.wang@....com>, abelvesa@...nel.org, festevam@...il.com, 
	imx@...ts.linux.dev, kernel@...gutronix.de, mturquette@...libre.com, 
	peng.fan@....com, s.hauer@...gutronix.de, shawnguo@...nel.org, 
	linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: imx: imx8: Add .name for "acm_aud_clk0_sel" and "acm_aud_clk1_sel"

On Tue, Jul 9, 2024 at 6:45 AM Stephen Boyd <sboyd@...nel.org> wrote:
>
> Quoting Shengjiu Wang (2024-07-03 01:52:51)
> > "acm_aud_clk0_sel" and "acm_aud_clk1_sel" are registered by this ACM
> > driver, but they are the parent clocks for other clocks, in order to
> > use assigned-clock-parents in device tree, they need to have the
> > global name.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> > ---
> >  drivers/clk/imx/clk-imx8-acm.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/clk/imx/clk-imx8-acm.c b/drivers/clk/imx/clk-imx8-acm.c
> > index 1bdb480cc96c..a1affcf6daff 100644
> > --- a/drivers/clk/imx/clk-imx8-acm.c
> > +++ b/drivers/clk/imx/clk-imx8-acm.c
> > @@ -114,8 +114,8 @@ static const struct clk_parent_data imx8qm_mclk_out_sels[] = {
> >  static const struct clk_parent_data imx8qm_mclk_sels[] = {
> >         { .fw_name = "aud_pll_div_clk0_lpcg_clk" },
> >         { .fw_name = "aud_pll_div_clk1_lpcg_clk" },
> > -       { .fw_name = "acm_aud_clk0_sel" },
> > -       { .fw_name = "acm_aud_clk1_sel" },
> > +       { .fw_name = "acm_aud_clk0_sel", .name = "acm_aud_clk0_sel" },
> > +       { .fw_name = "acm_aud_clk1_sel", .name = "acm_aud_clk1_sel" },
>
> This doesn't make any sense. Why are we adding fallback names?  Is
> "acm_aud_clk0_sel" not part of the DT binding for this clk controller?

It is not part of DT binding for this clk controller.  it is registered by this
clk controller itself.  As it is a parent clock, so my understanding
is that we need to add a fallback name,  or change "fw_name" to "name",
please correct me if I am wrong.

Best regards
Shengjiu Wang