linux-kernel - Re: [PATCH AUTOSEL 5.4 08/11] platform/x86: lg-laptop: Remove LGEX0815 hotkey handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d5e5d39-d53c-4650-8729-01cf0bf478c6@gmx.de>
Date: Tue, 9 Jul 2024 18:35:36 +0200
From: Armin Wolf <W_Armin@....de>
To: Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Cc: Agathe Boutmy <agathe@...tmy.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 Hans de Goede <hdegoede@...hat.com>, matan@...alib.org,
 platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.4 08/11] platform/x86: lg-laptop: Remove
 LGEX0815 hotkey handling

Am 09.07.24 um 18:26 schrieb Sasha Levin:

> From: Armin Wolf <W_Armin@....de>
>
> [ Upstream commit 413c204595ca98a4f33414a948c18d7314087342 ]
>
> The rfkill hotkey handling is already provided by the wireless-hotkey
> driver. Remove the now unnecessary rfkill hotkey handling to avoid
> duplicating functionality.
>
> The ACPI notify handler still prints debugging information when
> receiving ACPI notifications to aid in reverse-engineering.

Hi,

this depends on other patches not in kernel 5.4, please do not use this
patch for kernel 5.4.

Thanks,
Armin Wolf

> Tested-by: Agathe Boutmy <agathe@...tmy.com>
> Signed-off-by: Armin Wolf <W_Armin@....de>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> Link: https://lore.kernel.org/r/20240606233540.9774-3-W_Armin@gmx.de
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>   drivers/platform/x86/lg-laptop.c | 8 --------
>   1 file changed, 8 deletions(-)
>
> diff --git a/drivers/platform/x86/lg-laptop.c b/drivers/platform/x86/lg-laptop.c
> index c0bb1f864dfeb..27c456b517850 100644
> --- a/drivers/platform/x86/lg-laptop.c
> +++ b/drivers/platform/x86/lg-laptop.c
> @@ -79,7 +79,6 @@ static const struct key_entry wmi_keymap[] = {
>   					  * this key both sends an event and
>   					  * changes backlight level.
>   					  */
> -	{KE_KEY, 0x80, {KEY_RFKILL} },
>   	{KE_END, 0}
>   };
>
> @@ -261,14 +260,7 @@ static void wmi_input_setup(void)
>
>   static void acpi_notify(struct acpi_device *device, u32 event)
>   {
> -	struct key_entry *key;
> -
>   	acpi_handle_debug(device->handle, "notify: %d\n", event);
> -	if (inited & INIT_SPARSE_KEYMAP) {
> -		key = sparse_keymap_entry_from_scancode(wmi_input_dev, 0x80);
> -		if (key && key->type == KE_KEY)
> -			sparse_keymap_report_entry(wmi_input_dev, key, 1, true);
> -	}
>   }
>
>   static ssize_t fan_mode_store(struct device *dev,