linux-kernel - Re: [PATCH v2 1/4] i2c: smbus: only limit max banks to eight

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ee0b2612-afb4-4ccb-9afd-b0cfd7e26a6f@t-8ch.de>
Date: Tue, 9 Jul 2024 19:27:03 +0200
From: Thomas Weißschuh <thomas@...ch.de>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Jean Delvare <jdelvare@...e.com>, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH v2 1/4] i2c: smbus: only limit max banks to eight

Hi Andi,

On 2024-07-05 13:56:24+0000, Andi Shyti wrote:
> On Fri, Jul 05, 2024 at 07:55:21AM GMT, Thomas Weißschuh  wrote:
> > Jul 4, 2024 23:57:36 Andi Shyti <andi.shyti@...nel.org>:
> > > On Thu, Jun 27, 2024 at 07:48:11PM GMT, Thomas Weißschuh wrote:
> > >> If there are less than eight slots in total,
> > >> only probe those.
> > >> Now the code matches the comment "..., then limit slots to 8".
> > >>
> > >> Fixes: 8821c8376993 ("i2c: smbus: Prepare i2c_register_spd for usage on muxed segments")
> > >> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> > >
> > > I don't see the need for the Fixes here... was there a bug that
> > > has been fixed?
> > 
> > More addresses are probed than are possible.
> > Which is a change from the old behavior and also
> > contradicts the comment.
> > IMO it's a bug. Probably not a big one and I'm not sure if user-observable.
> > Surely nothing for stable.
> 
> The Fixes tag means that you want the patch to be backported to
> stable kernels. Someone will take the effort of taking all the
> new "Fixes:" and port them to older kernels.

It's my understanding that a Fixes tag itself is not enough for the
stable process. For that it also needs a "Cc: stable@...r.kernel.org" in
the patch or explicit notification of the stable team.
(Or being picked up by Autosel)

Anyways, I'll squash the commits and drop the Fixes tat, as there was no
bug as pointed out by Heiner.

> We want this when patches fix crashes, deadlocks, memory leaks,
> security holes, misbehaviours, earthquakes and floodings.
> 
> Andi
> 
> > But I'm not hung up on it and will drop that tag in the next revision.