linux-kernel - [PATCH v3 0/2] i2c: smbus cleanups and SPD support for piix4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240709-piix4-spd-v3-0-9d1daa204983@weissschuh.net>
Date: Tue, 09 Jul 2024 19:35:34 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Andi Shyti <andi.shyti@...nel.org>, Jean Delvare <jdelvare@...e.com>
Cc: linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Guenter Roeck <linux@...ck-us.net>, 
 Wolfram Sang <wsa+renesas@...g-engineering.com>, 
 Heiner Kallweit <hkallweit1@...il.com>, 
 Thomas Weißschuh <linux@...ssschuh.net>
Subject: [PATCH v3 0/2] i2c: smbus cleanups and SPD support for piix4

Patches 1 is a preparation patch.
Patch 2 is the actual change to piix4.

Patch 1 drops the warning about muxed busses.
I didn't feel that the warning only would warrant the additional
complexity it introduces with multiple callers of i2c_register_spd().

If others feel different, maybe a more generic warning/info or a source
code comment would suffice.

On a machine with 32 slots of which 16 are populated only the first 8
slots are addressable, half of which are empty.
Unfortunately I couldn't run a custom kernel for testing.
But manually instantiating ee1004 devices worked as expected,
so the proposed changes should also work.

Tested with spd5118 and two DIMMs.

Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
---
Changes in v3:
- Apply tags from Guenter
- Squash commits 1-3, and reword the message slightly
- Drop Fixes:
- Link to v2: https://lore.kernel.org/r/20240627-piix4-spd-v2-0-617ce47b8ff4@weissschuh.net

Changes in v2:
- Add new i2c-smbus prep patches
- Only register SPD for port 0
- Link to v1: https://lore.kernel.org/r/20240530-piix4-spd-v1-1-9cbf1abebf41@weissschuh.net

---
Thomas Weißschuh (2):
      i2c: smbus: remove i801 assumptions from SPD probing
      i2c: piix4: Register SPDs

 drivers/i2c/busses/Kconfig     |  1 +
 drivers/i2c/busses/i2c-piix4.c |  4 ++++
 drivers/i2c/i2c-smbus.c        | 15 ++++-----------
 3 files changed, 9 insertions(+), 11 deletions(-)
---
base-commit: 9746c2dd0307c80bd695e4e3065367f3e0154723
change-id: 20240530-piix4-spd-39c156b22959

Best regards,
-- 
Thomas Weißschuh <linux@...ssschuh.net>