linux-kernel - Re: [PATCH] ASoC: dt-bindings: cirrus,cs4270: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAE3Oz82KvEv3uJw-ha4RjXDuwqbMAy5ifEnK-gtR9ajkEbm-bA@mail.gmail.com>
Date: Tue, 9 Jul 2024 23:43:31 +0530
From: Animesh Agarwal <animeshagarwal28@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Daniel Baluta <daniel.baluta@....com>, David Rhodes <david.rhodes@...rus.com>, 
	Richard Fitzgerald <rf@...nsource.cirrus.com>, Liam Girdwood <lgirdwood@...il.com>, 
	Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, patches@...nsource.cirrus.com, 
	alsa-devel@...a-project.org, linux-sound@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: cirrus,cs4270: Convert to dtschema

xOn Mon, Jul 8, 2024 at 1:08 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 07/07/2024 08:26, Animesh Agarwal wrote:
> > +  va-supply:
> > +    description: Voltage regulator phandle for the VA supply.
>
> Your description is redundant: you did not say anything more than it is
> already said in the property name. This could be in such case just:
> ": true"
>
> Please keep this feedback for any future work (I feel I already said it
> once...).
>

I'll add proper descriptions for each of these instead, thanks for the heads-up.

> > +
> > +  vd-supply:
> > +    description: Voltage regulator phandle for the VD supply.
> > +
> > +  vlc-supply:
> > +    description: Voltage regulator phandle for the VLC supply.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
>
> This won't validate DTS... test the DTS. You miss dai-common.
>

Weirdly, this wasn't giving any errors upon running the dtbs_check,
however I should fix this.

> > +
> > +examples:
> > +  - |
> > +    i2c {
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +
> > +      codec: cs4270@48 {
>
> Node names should be generic. See also an explanation and list of
> examples (not exhaustive) in DT specification:
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> e.g. audio-codec or codec
>
> And drop unused label "codec:"
>

I can see some other cirrus bindings with this mistake, maybe because
they were written/converted several years ago. I shall fix it here.

>
> Best regards,
> Krzysztof
>