linux-kernel - Re: [PATCH] floppy: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <389aa594-5c58-4740-8079-3c2c88754be7@quicinc.com>
Date: Tue, 9 Jul 2024 12:56:24 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: <efremov@...ux.com>, Jens Axboe <axboe@...nel.dk>
CC: <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] floppy: add missing MODULE_DESCRIPTION() macro

On 6/3/2024 3:35 AM, Denis Efremov (Oracle) wrote:
> On 6/3/24 04:05, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>> ---
>>  drivers/block/floppy.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
>> index 25c9d85667f1..854a88cf56bd 100644
>> --- a/drivers/block/floppy.c
>> +++ b/drivers/block/floppy.c
>> @@ -5016,6 +5016,7 @@ module_param(floppy, charp, 0);
>>  module_param(FLOPPY_IRQ, int, 0);
>>  module_param(FLOPPY_DMA, int, 0);
>>  MODULE_AUTHOR("Alain L. Knaff");
>> +MODULE_DESCRIPTION("Normal floppy disk support");
>>  MODULE_LICENSE("GPL");
>>  
>>  /* This doesn't actually get used other than for module information */
>>
>> ---
>> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
>> change-id: 20240602-md-block-floppy-1984117350ec
>>
> 
> Reviewed-by: Denis Efremov <efremov@...ux.com>

I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.