linux-kernel - Re: [PATCH] ublk_drv: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5a080f52-5486-4bb4-ab52-59cc0ab2589e@quicinc.com>
Date: Tue, 9 Jul 2024 13:00:13 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Ming Lei <ming.lei@...hat.com>, Jens Axboe <axboe@...nel.dk>
CC: <linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] ublk_drv: add missing MODULE_DESCRIPTION() macro

On 6/2/2024 5:53 PM, Ming Lei wrote:
> On Sun, Jun 02, 2024 at 05:23:26PM -0700, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ublk_drv.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>> ---
>>  drivers/block/ublk_drv.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
>> index 4e159948c912..59916895ee2e 100644
>> --- a/drivers/block/ublk_drv.c
>> +++ b/drivers/block/ublk_drv.c
>> @@ -3017,4 +3017,5 @@ module_param_cb(ublks_max, &ublk_max_ublks_ops, &ublks_max, 0644);
>>  MODULE_PARM_DESC(ublks_max, "max number of ublk devices allowed to add(default: 64)");
>>  
>>  MODULE_AUTHOR("Ming Lei <ming.lei@...hat.com>");
>> +MODULE_DESCRIPTION("Userspace block device");
>>  MODULE_LICENSE("GPL");
> 
> Reviewed-by: Ming Lei <ming.lei@...hat.com>

I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.