linux-kernel - Re: [PATCH v2 09/60] i2c: cp2615: reword according to newest specification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fihr4etj2t36nlg7zftjvmi24hv7z4oene5tfjzxt6eejponxq@ighv4j3xhrty>
Date: Wed, 10 Jul 2024 00:15:17 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>, 
	Bence Csókás <bence98@....bme.hu>, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 09/60] i2c: cp2615: reword according to newest
 specification

Hi,

> > > -	.master_xfer	= cp2615_i2c_master_xfer,
> > > -	.functionality	= cp2615_i2c_func,
> > > +	.xfer = cp2615_i2c_xfer,
> > > +	.functionality = cp2615_i2c_func,
> > >   };
> > >   /*
> > 
> > I don't understand the need for the whitespace changes.
> 
> If you have only one space in such struct initializations, you can
> change later only the line you are interested in. If you have aligned
> them with tabs, you sometimes change one line and need to realign the
> whole block. This is annoying and spoils history a little.

TBH looks also better. For just to fields in the struct I don't
see it necessary to put the elements in columns.

Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

Andi