linux-kernel - Re: [PATCH v3 1/2] i2c: smbus: remove i801 assumptions from SPD probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dbajkputlzoqukkjymfq7jd6jb4hz3o7q2f7fsbany2vqcx5dj@xhwltuotxqr5>
Date: Wed, 10 Jul 2024 00:33:24 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Jean Delvare <jdelvare@...e.com>, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, Heiner Kallweit <hkallweit1@...il.com>
Subject: Re: [PATCH v3 1/2] i2c: smbus: remove i801 assumptions from SPD
 probing

On Tue, Jul 09, 2024 at 07:35:35PM GMT, Thomas Weißschuh wrote:
> The check and warning are very specific to the SPD usage of the i801
> driver. That was fine as long as i801 was the only caller of
> i2c_register_spd(). Now that piix4 will be added as another user of that
> function, the check and warning are not accurate anymore.
> Instead of introducing a more complicated calling protocol only to print
> a warning, drop the warning.

Well... it's not just a warning, it also returns.

> Even in cases where not all slots can be probed,
> then at least probe the 8 slots that can be.

I'm good with the change.

Jean, Heiner, any comment here? Do we want to add an extra check
for i801?

Andi