linux-kernel - Re: [PATCH v2 5/5] loop: Don't bother validating blocksize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b51be09f-6b7b-4f21-98aa-4e6e8d64d00f@kernel.org>
Date: Tue, 9 Jul 2024 14:39:45 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: John Garry <john.g.garry@...cle.com>, axboe@...nel.dk, mst@...hat.com,
 jasowang@...hat.com, xuanzhuo@...ux.alibaba.com, eperezma@...hat.com,
 pbonzini@...hat.com, stefanha@...hat.com, hare@...e.de, kbusch@...nel.org,
 hch@....de
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
 virtualization@...ts.linux.dev
Subject: Re: [PATCH v2 5/5] loop: Don't bother validating blocksize

On 7/8/24 18:16, John Garry wrote:
> The block queue limits validation does this for us now.
> 
> The loop_configure() -> WARN_ON_ONCE() call is dropped, as an invalid
> block size would trigger this now. We don't want userspace to be able to
> directly trigger WARNs.
> 
> Reviewed-by: Christoph Hellwig <hch@....de>
> Signed-off-by: John Garry <john.g.garry@...cle.com>

Reviewed-by: Damien Le Moal <dlemoal@...nel.org>

-- 
Damien Le Moal
Western Digital Research