linux-kernel - Re: [PATCH] tpm: Move dereference after NULL check in tpm_buf_check_hmac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fc4323b7-c7f9-47c5-a7eb-4034d2e18bcf@web.de>
Date: Tue, 9 Jul 2024 08:04:26 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Hao Ge <gehao@...inos.cn>, linux-integrity@...r.kernel.org,
 Jarkko Sakkinen <jarkko@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>,
 Peter Hüwe <peterhuewe@....de>
Cc: Hao Ge <hao.ge@...ux.dev>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tpm: Move dereference after NULL check in
 tpm_buf_check_hmac_response

> We shouldn't dereference "auth" until after we have checked that it is
> non-NULL.

How do you think about to improve such a change description with imperative wordings?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc7#n94

> Fixes: 7ca110f2679b ("tpm: Address !chip->auth in tpm_buf_append_hmac_session*()")

1. Would the commit 1085b8276bb4239daa7008f0dcd5c973e4bd690f ("tpm:
   Add the rest of the session HMAC API") be more appropriate as a reference?

2. Would you like to add a “stable tag” accordingly?
   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.10-rc7#n34

3. How do you think about to append parentheses to a function name
   in the summary phrase?

Regards,
Markus