linux-kernel - RE: [PATCH] x86/tdx: Support vmalloc() for tdx_enc_status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <SA1PR21MB131747711B9BC5F293139FA1BFDB2@SA1PR21MB1317.namprd21.prod.outlook.com>
Date: Tue, 9 Jul 2024 07:13:56 +0000
From: Dexuan Cui <decui@...rosoft.com>
To: Jiri Slaby <jirislaby@...nel.org>, Borislav Petkov <bp@...en8.de>
CC: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Dave Hansen
	<dave.hansen@...ux.intel.com>, Thomas Gleixner <tglx@...utronix.de>, Ingo
 Molnar <mingo@...hat.com>, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
	<x86@...nel.org>, "H. Peter Anvin" <hpa@...or.com>, "open list:X86 TRUST
 DOMAIN EXTENSIONS (TDX)" <linux-coco@...ts.linux.dev>, "open list:X86
 ARCHITECTURE (32-BIT AND 64-BIT)" <linux-kernel@...r.kernel.org>, Michael
 Kelley <mikelley@...rosoft.com>, Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@...ux.intel.com>, Rick Edgecombe
	<rick.p.edgecombe@...el.com>, Kai Huang <kai.huang@...el.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: RE: [PATCH] x86/tdx: Support vmalloc() for tdx_enc_status_changed()

> From: Jiri Slaby <jirislaby@...nel.org>
>  [...]
> If you cc stable, fixes *is* actually needed. So again, why to cc stable
Ok, I can add a tag to next version, i.e., v12:
Fixes: 68f2f2bc163d ("Drivers: hv: vmbus: Support fully enlightened TDX guests")

68f2f2bc163d is already in v6.6.
A v6.6 kernel works for a Linux TD-Mode TDX VM on Hyper-V, if the VM
doesn't have a virtual NIC device; if the VM has a vNIC, the hv_netvsc driver
fails to load and the VM gets stuck in the network init script. This patch fixes
the issue.

> when this is a feature? I suppose you will receive a Greg-bot reply
> anyway ;).
As explained above, my understanding is that this is more of a bug fix rather
than a feature, though the described NIC driver issue is specific to Hyper-V.
In the future, there might be new users of vmalloc() + set_memory_decrypted().

> > How do you like the v12 below? It's also attached.
> > If this looks good to you, I can post it today or tomorrow.
> 
> Then you need to enumerate what changed in v1..v12. In every single
> revision. Do it under the "---" line below. And add v12 to the subject
> as you did below (but not above).
Ok, I'll post v12 tomorrow with changes enumerated from v1..v12.
 
> >  From 132f656fdbf3b4f00752140aac10f3674b598b5a Mon Sep 17
> 00:00:00 2001
> > From: Dexuan Cui <decui@...rosoft.com>
> > Date: Mon, 20 May 2024 19:12:38 -0700
> > Subject: [PATCH v12] x86/tdx: Fix set_memory_decrypted() for vmalloc()
> buffers
> >
> ...
> >
> > hv_netvsc is the first user of vmalloc() + set_memory_decrypted(), which
> > is why nobody noticed this until now.
> >
> > Co-developed-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > Signed-off-by: Dexuan Cui <decui@...rosoft.com>
> > Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
> > Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
> > Reviewed-by: Kuppuswamy Sathyanarayanan
> <sathyanarayanan.kuppuswamy@...ux.intel.com>
> > Reviewed-by: Rick Edgecombe <rick.p.edgecombe@...el.com>
> > Reviewed-by: Dave Hansen <dave.hansen@...ux.intel.com>
> > Acked-by: Kai Huang <kai.huang@...el.com>
> > Cc: stable@...r.kernel.org # 6.6+
> > ---
> 
> The revision log belongs here. I believe you had to meet that
> requirement in the submittingpatches document.
Ok, will do.

> And to avoid future confusion, I would list the links to received
> "Signed-off-by"/"Reviewed-by"s here too. The links you listed earlier.
Ok, will do.

> regards,
> --
> js
> suse labs

Thanks for your comments!