linux-kernel - Re: [PATCH v2 00/13] forcealign for xfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240709074802.GC21491@lst.de>
Date: Tue, 9 Jul 2024 09:48:02 +0200
From: Christoph Hellwig <hch@....de>
To: John Garry <john.g.garry@...cle.com>
Cc: Christoph Hellwig <hch@....de>, chandan.babu@...cle.com,
	djwong@...nel.org, dchinner@...hat.com, viro@...iv.linux.org.uk,
	brauner@...nel.org, jack@...e.cz, linux-xfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	catherine.hoang@...cle.com, martin.petersen@...cle.com
Subject: Re: [PATCH v2 00/13] forcealign for xfs

On Mon, Jul 08, 2024 at 08:48:19AM +0100, John Garry wrote:
> I am not sure what that pain is, but I guess it's the maintainability and 
> scalability of the scattered "if RT" checks for rounding up and down to 
> larger extent size, right?
>
> For forcealign, at least we can factor that stuff mostly into common 
> forcealign+RT helpers, to keep the checks common. That is apart from the 
> block allocator code.

Maybe its just me hating all the rtalloc larger than block size
allocation granularity mess and hoping it goes away.  With this we'll
make it certain that it is not going away, but that might just have
been a faint hope.  But if we add more of it we'll at least need to
ensure it is done using common helpers and clean the existing mess up
as much as we can.